Allow Upper Case property names#1037
Merged
Merged
Conversation
Contributor
Author
|
I forgot to modify Behat scenarios |
Member
|
I strongly encourage you to test it with a new entity instead of modifying an existing one. It will be less painful than editing Behat tests. |
ReflectionExtractor::getProperties() returns $id instead of $Id. It is bad naming convention, but is possible
```
use ApiPlatform\Core\Annotation\ApiProperty;
use Doctrine\ORM\Mapping as ORM;
class Entity {
/**
* @var string The dummy Guid
*
* @Orm\Column(nullable=true)
* @ApiProperty()
*/
protected $Id;
public function getId()
{
return $this->Id;
}
}
```
soyuka
approved these changes
Apr 7, 2017
meyerbaptiste
requested changes
Apr 7, 2017
| /** | ||
| * Custom identifier dummy. | ||
| * | ||
| * @author Exploit.cz <insekticid@exploit.cz> |
Contributor
Author
There was a problem hiding this comment.
oh, cool. someone is reading my code
because of this
https://github.com/api-platform/core/blob/master/tests/Fixtures/TestBundle/Entity/CircularReference.php#L22
and this
https://github.com/api-platform/core/blob/master/tests/Fixtures/TestBundle/Entity/AbstractDummy.php#L22
etc
Member
There was a problem hiding this comment.
lol no I wondered the same
IMO we should keep as @author the one who created the class not uppon each edit :). Should be fixed in other classes too. Still, what's the point of adding @author when we can git blame?
Member
There was a problem hiding this comment.
@insekticid I have no problems with the @author tag but you made no changes on this class! 😄
Add it to the UpperCaseIdentifierDummy class instead, it's more relevant! 😉
Contributor
|
Shouldn't we add a behat test case to check ? @dunglas |
Member
|
@Simperfit no need to add a behat test here IMO, our behat suite is heavy enough (and painful to maintain too). The unit test covers the use case just fine! |
Contributor
Author
|
Sorry. I do not have any more time solving this simple stupid issue with
authoring this fix. I lost about 15hours of investigating bug with
xdebug+fix+phpunit. It is now up to you. You are allowed to change my pull.
…On 8 Apr 2017 1:11 a.m., "Baptiste Meyer" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/Fixtures/TestBundle/Entity/UuidIdentifierDummy.php
<#1037 (comment)>:
> @@ -17,6 +17,8 @@
/**
* Custom identifier dummy.
*
+ * @author Exploit.cz ***@***.***>
@insekticid <https://github.com/insekticid> I have no problems with the
@author tag but you made no changes on this class! 😄
Add it to the UpperCaseIdentifierDummy class instead, it's more relevant!
😉
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1037 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAK0vAl5144hR9T_-eHNLkFgITLhmdr0ks5rtsKOgaJpZM4M2zwl>
.
|
Member
|
Don't worry I can do the change during the merge. |
Member
|
Thanks @insekticid ! |
This was referenced Apr 27, 2017
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Apr 29, 2017
…ticid) This PR was merged into the 2.8 branch. Discussion ---------- Allow Upper Case property names in ObjectNormalizer | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22547 | License | MIT Same problem that has been fixed here #22265 and here api-platform/core#1037 ObjectNormalizer returns $id instead of $Id. It is bad naming convention, but is possible ```php class Entity { protected $Id; public function getId() { return $this->Id; } } ``` Commits ------- b2b4faa Allow Upper Case property names in ObjectNormalizer
symfony-splitter
pushed a commit
to symfony/serializer
that referenced
this pull request
Apr 29, 2017
| Q | A | ---------------- | ----- | Bug report? | yes | Feature request? | no | BC Break report? | yes | RFC? | no | Symfony version | 2.8.19 Same problem that has been fixed here symfony/symfony#22265 and here api-platform/core#1037 ObjectNormalizer returns $id instead of $Id. It is bad naming convention, but is possible ```php class Entity { protected $Id; public function getId() { return $this->Id; } } ```
symfony-splitter
pushed a commit
to symfony/serializer
that referenced
this pull request
Apr 29, 2017
…ticid) This PR was merged into the 2.8 branch. Discussion ---------- Allow Upper Case property names in ObjectNormalizer | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22547 | License | MIT Same problem that has been fixed here symfony/symfony#22265 and here api-platform/core#1037 ObjectNormalizer returns $id instead of $Id. It is bad naming convention, but is possible ```php class Entity { protected $Id; public function getId() { return $this->Id; } } ``` Commits ------- b2b4faa Allow Upper Case property names in ObjectNormalizer
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
Allow Upper Case property names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReflectionExtractor::getProperties() returns $id instead of $Id. It is bad naming convention, but is possible